Soundship
/
Loopp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

timemanager: replace sprintf() with snprintf() 

This avoids buffer overflows.

Signed-off-by: Harry van Haaren <harryhaaren@gmail.com>
main
Harry van Haaren 2018-07-21 00:03:07 +01:00
parent e3491dbe5f
commit 4edd419a63
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/timemanager.cxx
View File

@ -110,7 +110,8 @@ void TimeManager::setFpb(double f)
int bpm = ( samplerate * 60) / f;
char buffer [50];
sprintf (buffer, "TM, setFpb() %i, bpm = %i", int(f), int(bpm) );
snprintf(buffer, sizeof(buffer), "TM, setFpb() %i, bpm = %i",
int(f), int(bpm) );
EventGuiPrint e( buffer );
writeToGuiRingbuffer( &e );
@ -153,14 +154,16 @@ void TimeManager::tap()
if( average < 13000 ) {
char buffer [50];
sprintf (buffer, "TM, tap() average too slow! quitting");
snprintf(buffer, sizeof(buffer),
"TM, tap() average too slow! quitting");
EventGuiPrint e( buffer );
writeToGuiRingbuffer( &e );
return;
}
char buffer [50];
sprintf (buffer, "TM, tap() average = %i", average );
snprintf(buffer, sizeof(buffer), "TM, tap() average = %i",
average);
EventGuiPrint e( buffer );
writeToGuiRingbuffer( &e );
@ -217,13 +220,16 @@ void TimeManager::process(Buffers* buffers)
if ( before < nframes && after <= nframes && before + after == nframes ) {
char buffer [50];
// sprintf (buffer, "Timing OK: before %i, after %i, b+a %i", before, after, before+after );
// snprintf(buffer, sizeof(buffer), "Timing OK: before %i, after %i, b+a %i",
// before, after, before+after );
// EventGuiPrint e2( buffer );
// writeToGuiRingbuffer( &e2 );
} else {
char buffer [50];
sprintf (buffer, "Timing Error: before: %i, after %i", before, after );
snprintf(buffer, sizeof(buffer),
"Timing Error: before: %i, after %i",
before, after );
EventGuiPrint e2( buffer );
writeToGuiRingbuffer( &e2 );
}