From a702630f40aef8aedfbd16493ab42b9aea18a9a4 Mon Sep 17 00:00:00 2001 From: Harry van Haaren Date: Thu, 5 Sep 2013 23:45:06 +0100 Subject: [PATCH] -Cleanup, kick some old files --- FIXME | 5 ----- TODO | 27 --------------------------- src/avtk/avtk_volume.h | 4 ---- src/jack.cxx | 1 + 4 files changed, 1 insertion(+), 36 deletions(-) delete mode 100644 FIXME delete mode 100644 TODO diff --git a/FIXME b/FIXME deleted file mode 100644 index 35c2509..0000000 --- a/FIXME +++ /dev/null @@ -1,5 +0,0 @@ - -=TrackOutput, progress should use Logic, not write events to GUI - -=TimeManager class, auto register TimeObservers with it. - Segfaulting on register in constructor diff --git a/TODO b/TODO deleted file mode 100644 index 1eb9303..0000000 --- a/TODO +++ /dev/null @@ -1,27 +0,0 @@ - -=== NEW --Update SIDE control to blue button --Add track recordArm functionality to record over loaded loops - -- Remove TimeObserver obligation from Looper, not needed as GridLogic handles Time now - -- Add AudioBuffer soundfile writer in order to check contents (looper distortion bug) - -- Update GUI threading to become controller independant, allowing a -ControllerUpdater instance run in the UI thread, updating each Controller -subclass instance. This affords OSC user-interfaces, as well a the GUI, as well -as future controllers. - - thread per Controller - - deriving from TimeManager etc not possible, should they be functions in - Controller, so that moving a class from RT to non-RT won't = code change - -=== IN PROGRESS - - - -=== COMPLETED - -- Interface / Logic class for all Luppp engines actions -Needed to give Controller classes a way to tell Luppp what to do. -This class must update all controllers based on state. Essentially -its like "GridLogic", but for the rest of the functionality. diff --git a/src/avtk/avtk_volume.h b/src/avtk/avtk_volume.h index 5f311c5..00aba17 100644 --- a/src/avtk/avtk_volume.h +++ b/src/avtk/avtk_volume.h @@ -28,8 +28,6 @@ #include #include -extern void luppp_tooltip(std::string s); - namespace Avtk { @@ -213,8 +211,6 @@ class Volume : public Fl_Slider } return 1; case FL_ENTER: - // push help string to UI tooltip area - luppp_tooltip( "Volume" ); return 1; case FL_RELEASE: if (highlight) { diff --git a/src/jack.cxx b/src/jack.cxx index 5b9c1bd..c063364 100644 --- a/src/jack.cxx +++ b/src/jack.cxx @@ -322,6 +322,7 @@ int Jack::getSamplerate() void Jack::writeApcOutput( unsigned char* data ) { + // FIXME: MIDI output needs a QUEUE structure, so we can send more data to the APC "at once" void* apcOutput = buffers.midi[Buffers::APC_OUTPUT]; unsigned char* buf = jack_midi_event_reserve( apcOutput, 0, 3);