Added optional change of docker root dir #1

Merged
gcrkrause merged 4 commits from 115-change-docker-root into main 2021-06-03 20:44:38 +02:00
There is no content yet.
thiuda added 1 commit 2021-06-03 17:59:25 +02:00
thiuda requested review from gcrkrause 2021-06-03 18:00:02 +02:00
gcrkrause approved these changes 2021-06-03 19:56:01 +02:00
gcrkrause left a comment
Owner

Sorry, but I don't like!

  1. This will conflict as soon as we want to apply any other configuration to the daemon.
  2. If the variable is not set, we should just use a default value
Sorry, but I don't like! 1. This will conflict as soon as we want to apply any other configuration to the daemon. 2. If the variable is not set, we should just use a [default value](https://jinja2docs.readthedocs.io/en/stable/templates.html#default)
gcrkrause requested changes 2021-06-03 19:56:10 +02:00
gcrkrause left a comment
Owner

Sorry, but I don't like!

  1. This will conflict as soon as we want to apply any other configuration to the daemon.
  2. If the variable is not set, we should just use a default value
Sorry, but I don't like! 1. This will conflict as soon as we want to apply any other configuration to the daemon. 2. If the variable is not set, we should just use a [default value](https://jinja2docs.readthedocs.io/en/stable/templates.html#default)
thiuda added 1 commit 2021-06-03 20:40:31 +02:00
thiuda added 1 commit 2021-06-03 20:42:38 +02:00
thiuda added 1 commit 2021-06-03 20:43:09 +02:00
gcrkrause approved these changes 2021-06-03 20:44:33 +02:00
gcrkrause merged commit 7daabf03c0 into main 2021-06-03 20:44:38 +02:00
Sign in to join this conversation.
There is no content yet.