Rework exporter #10

Merged
gcrkrause merged 3 commits from rework_export into main 2023-05-03 14:48:10 +02:00
Collaborator
There is no content yet.
moanos added 1 commit 2023-05-03 11:31:29 +02:00
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is passing Details
46b0fe6b50
Rework exporter
moanos added 1 commit 2023-05-03 11:54:06 +02:00
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is passing Details
7d986a7072
Update help
gcrkrause approved these changes 2023-05-03 14:43:17 +02:00
gcrkrause left a comment
Owner

Looks good, only some minor things

Looks good, only some minor things
@ -42,0 +50,4 @@
exported_text = blocklist_to_markdown(blocklist, private)
if output is not None:
with open(output, "w") as f:
f.write(exported_text)

Isn't this a duplication of line 60-62?

Isn't this a duplication of line 60-62?
@ -54,2 +80,4 @@
parser.add_argument('-v', '--verbose', action='store_true')
parser.add_argument('-n', '--no-delete', action='store_true', help="Do not delete existing blocks")
parser.add_argument('--format', help="Export format: toml|markdown")
parser.add_argument('--private', action='store_true', help="When the flag is set private comment will also be "

Adding a , after is set helps to understand this easier :D (I was super confused when reading this first)

Adding a `,` after `is set` helps to understand this easier :D (I was super confused when reading this first)
moanos marked this conversation as resolved
moanos added 1 commit 2023-05-03 14:46:25 +02:00
continuous-integration/drone/pr Build is failing Details
continuous-integration/drone/push Build is passing Details
fe12631ee4
Remove double output, typo
gcrkrause merged commit a646714f76 into main 2023-05-03 14:48:10 +02:00
gcrkrause deleted branch rework_export 2023-05-03 14:48:11 +02:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Lediver.se/fediverse-blocklist-deploy#10
There is no content yet.